feat(useSeek): Add seekAll and seekAllByName methods to useSeek composable
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andretchen0
changed the title
seekAll and seekAllByName methods to useSeek composableseekAll and seekAllByName methods to useSeek composable
|
I updated the PR title, so the linter doesn't flag it. Just FYI, here's the expected format for titles. |
alvarosabu
requested changes
Nov 4, 2023
There was a problem hiding this comment.
We are almost there @garrlker:
- Please add the documentation for this composable on
docs/guide/use-seek.md - Check the comment on the evaluation of strings
… useSeek documentation to include these 2 new functions
|
@andretchen0 Thanks! I'll keep that in mind. Also I've never seen the conventional commits site before, double thanks for that! @alvarosabu I updated the documentation with a very barebones example/description and used |
alvarosabu
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #236
Tldr;
seekAllandseekAllByNameare the same asseekandseekByNameexcept that they return an array of all matches instead of the first match.Both methods return an empty array
[]when there are no matches