refactor(TextureLoader): use THREE.DefaultLoadingManager as default loading manager #432
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Sorry for the delay. I'm not at home right now, so feedback will be slow. I'm also not very clued into how Tres is working behind the scenes, so I'm not sure I'm the person to give a thumbs up or down here. @alvarosabu, I'm fine with whatever you decide. |
andretchen0
changed the title
andretchen0
changed the title
|
FYI, updated the PR title using the conventions here, in order to pass the linter check. |
There was a problem hiding this comment.
I like the idea of using the THREE defaults.
I wonder if we'd be better off in the long run if we used the THREE TextureLoader signature. I.e., allow the user to pass their own LoadingManager. If they don't, use the default.
I'll go along with whatever @alvarosabu decides here.
|
@andretchen0 I agree with your idea, I think I prefer the user to be able to pass the loading manager they want. @hawk86104 could you add that to the PR? |
|
yeYes, I have submitted it ： #471
| |
hawk
|
|
***@***.***
|
…---- Replied Message ----
| From | Alvaro ***@***.***> |
| Date | 12/13/2023 16:52 |
| To | ***@***.***> |
| Cc | ***@***.***> ,
***@***.***> |
| Subject | Re: [Tresjs/tres] refactor(TextureLoader): use THREE.DefaultLoadingManager as default loading manager (PR #432) |
@andretchen0 I agree with your idea, I think I prefer the user to be able to pass the loading manager they want. @hawk86104 could you add that to the PR?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
fiexd TextureLoader use THREE.DefaultLoadingManager as default loading manager Tresjs#432
fiexd TextureLoader use THREE.DefaultLoadingManager as default loading manager form: Tresjs#432
* fix(deps):Update useTexture/index.ts fiexd TextureLoader use THREE.DefaultLoadingManager as default loading manager form: #432 * feat: Update src/composables/useTexture/index.ts remove the comment Co-authored-by: Alvaro Saburido <[email protected]> * feat: the documentation under docs/ to reflect 'allow custom loading manager to useTexture' --------- Co-authored-by: Alvaro Saburido <[email protected]>
I don't know if I should submit this type of pull request as a direct "create pull request" or as a "create draft pull request."