Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): 427 vueprops change ref to vnoderef and key add nu… #428

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

PatrickByrn
Copy link
Contributor

types (fix #427)

Updated ref in VueProps to use VNodeRef type from vue, to support using a function ref. Also updated key to accept numbers and symbols

#427

…add number and symbol

Updated `ref` in VueProps to use `VNodeRef` type from vue, to support using a function ref. Also updated key to accept numbers and symbols

Tresjs#427 Tresjs#427
@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit c5cd6b0
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/653ebca3554deb0008d6d716
😎 Deploy Preview https://deploy-preview-428--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu changed the title fix(types-(fix-#427)): vueprops change ref to vnoderef and key add nu… fix(types): 427 vueprops change ref to vnoderef and key add nu… Oct 30, 2023
@alvarosabu alvarosabu self-requested a review October 30, 2023 10:34
@alvarosabu alvarosabu added bug Something isn't working types labels Oct 30, 2023
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatrickByrn thanks a lot of the fix 🙏🏻

@alvarosabu alvarosabu merged commit 45aeafd into Tresjs:main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

ref prop missing type for functional ref
2 participants