Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: context (TresContext) is now exposed from TresCanvas #404

Merged
merged 5 commits into from
Sep 22, 2023
Merged

feat: context (TresContext) is now exposed from TresCanvas #404

merged 5 commits into from
Sep 22, 2023

Conversation

Tinoooo
Copy link
Contributor

@Tinoooo Tinoooo commented Sep 22, 2023

No description provided.

@Tinoooo Tinoooo linked an issue Sep 22, 2023 that may be closed by this pull request
Expose context (TresContext) in TresCanvas #403
Closed
4 tasks
@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit d141e94
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/650dc3808c18e900083fc2b0
😎 Deploy Preview https://deploy-preview-404--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tinoooo Tinoooo self-assigned this Sep 22, 2023
@alvarosabu
Copy link
Member

@Tinoooo should we add this to the docs?

@Tinoooo
Copy link
Contributor Author

Tinoooo commented Sep 22, 2023

@Tinoooo should we add this to the docs?

Yes! I forgot. I'm going to add the content now.

JaimeTorrealba
JaimeTorrealba reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the tres-canvas page is a nice one!!

docs/api/composables.md Show resolved Hide resolved
JaimeTorrealba
JaimeTorrealba approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote some comments, but I'll approve, thanks for the docs, It's really useful for me :)

docs/api/composables.md Outdated Show resolved Hide resolved
docs/api/composables.md Show resolved Hide resolved
docs/api/composables.md Outdated Show resolved Hide resolved
@alvarosabu
Copy link
Member

I like the new structure @Tinoooo very well done

@alvarosabu alvarosabu merged commit 838d779 into main Sep 22, 2023
6 checks passed
@Tinoooo Tinoooo deleted the feature/403-expose-context-trescontext-in-trescanvas branch September 25, 2023 07:11
@JaimeTorrealba JaimeTorrealba mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaimeTorrealba JaimeTorrealba JaimeTorrealba approved these changes

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees

@Tinoooo Tinoooo

Labels
None yet
Projects
Team Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose context (TresContext) in TresCanvas
3 participants
@Tinoooo @alvarosabu @JaimeTorrealba