Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): useTexture() #401

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

posva
Copy link
Contributor

@posva posva commented Sep 21, 2023

Correctly infer the return type based on the argument.

Note: I would personally have accepted a single string rather than [string] to build a single Texture but that would be a breaking change

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 863a55f
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/650c21f04eb0c400084de25d
😎 Deploy Preview https://deploy-preview-401--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu
Copy link
Member

@posva you're right, lets keep it like you changed for the moment. I will write it down for a potential v4 in the future.

@alvarosabu alvarosabu self-requested a review September 21, 2023 11:57
@alvarosabu alvarosabu merged commit 20ffa4b into Tresjs:main Sep 21, 2023
4 checks passed
@alvarosabu
Copy link
Member

Thanks for fixing this @posva

@posva posva deleted the fix/types-useTexture branch September 21, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants