Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming methods of the useCamera composable to prevent confusion #379

Closed
4 tasks done
Tinoooo opened this issue Aug 24, 2023 · 0 comments · Fixed by #380
Closed
4 tasks done

renaming methods of the useCamera composable to prevent confusion #379

Tinoooo opened this issue Aug 24, 2023 · 0 comments · Fixed by #380
Assignees
@Tinoooo

Comments

@Tinoooo
Copy link
Contributor

Tinoooo commented Aug 24, 2023

Description

The methods addCamera and removeCamera are named unfavorable (by me 😁). An might lead to confusion as happener here Their name might suggest, that a camera is added to the scene, which it is not.

Suggested solution

renaming the methods

Alternative

No response

Additional context

No response

Validations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tinoooo Tinoooo

Labels
None yet
Projects
Team Board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: renamed useCamera composable methods to prevent confusion Tresjs/tres
1 participant
@Tinoooo