Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 317 devtools #375

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: 317 devtools #375

merged 3 commits into from
Aug 23, 2023

Conversation

enpitsuLin
Copy link
Collaborator

separate the PR #365

@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit d17be07
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/64e590c6473dac0008510e35
😎 Deploy Preview https://deploy-preview-375--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu
Copy link
Member

@enpitsuLin Thanks a lot for separating the PRs now is easier as well to explain changes with the core team 🙏🏻 Thanks for taking the time

@alvarosabu
Copy link
Member

There is an error on the console, but not sure if it is something related to us 😂 or is the devtools issue

backend.js:2930 TypeError: Cannot read properties of null (reading '__VUE_DEVTOOLS_APP_RECORD__')
    at getAppRecord (backend.js:1131:28)
    at performanceMarkStart (backend.js:2894:52)
    at Object.<anonymous> (backend.js:2149:43)
    at Object.emit (<anonymous>:1:2255)
    at Object._replayBuffer (<anonymous>:1:1792)
    at Object.on (<anonymous>:1:1887)
    at connect (backend.js:2148:22)
    ```

alvarosabu
alvarosabu approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Everything works

@alvarosabu alvarosabu merged commit 9461a78 into main Aug 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

@Tinoooo Tinoooo Awaiting requested review from Tinoooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enpitsuLin @alvarosabu