Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fake a VNodeRef on types to accept strings and null #344

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: fake a VNodeRef on types to accept strings and null #344

merged 2 commits into from
Jul 11, 2023

Conversation

alvarosabu
Copy link
Member

Closes #301

@alvarosabu alvarosabu added bug Something isn't working dx labels Jul 11, 2023
@alvarosabu alvarosabu requested a review from Tinoooo July 11, 2023 09:17
@alvarosabu alvarosabu self-assigned this Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 5a88d18
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/64ad3ec5a0ef6d00082ba51a
😎 Deploy Preview https://deploy-preview-344--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Tinoooo
Tinoooo approved these changes Jul 11, 2023
View reviewed changes
src/types/index.ts Outdated Show resolved Hide resolved
@alvarosabu alvarosabu merged commit c069f64 into main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinoooo Tinoooo Tinoooo approved these changes

Assignees

@alvarosabu alvarosabu

Labels
bug Something isn't working dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript compiler error for refs with tresjs
2 participants
@alvarosabu @Tinoooo