feat: 331 new context for state tino #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarosabu
changed the title
|
I just pushed the |
alvarosabu
requested changes
Jul 7, 2023
I fixed this one in a7c0ada. The loop didn't start right away. Was/Is there a special necessity for it to not start immediately? Maybe I'm missing something here. |
…Tresjs/tres into feature/331-new-context-for-state__tino
I changed it that way 👍. |
|
@Tinoooo we need to add this to the state |
|
@Tinoooo at the end we don't need to add the appContext but we do need to add the 'raycaster' on the state for the HTML implementation Tresjs/cientos#23 implementation When you have some time please check what's left on this PR? |
|
@alvarosabu I am now back from vacation, so I think I can find today or in the coming days. |
alvarosabu
approved these changes
Jul 24, 2023
alvarosabu
approved these changes
Jul 24, 2023
alvarosabu
added a commit
that referenced
this pull request
Jul 29, 2023
* feat: tres context provider * feat: useContextProvider onMounted * feat: revert width height composables * feat: fixed renderer watch for aspectRatio changes * chore: clean up * feat: refactor raycaster * feat: 331 new context for state tino (#340) * feat: refactored composables; seperated logic from TresCanvas * chore: more changes concerning renderer composable * feat: made window size reactive * chore: made compasable params more uniform * chore: refactored useRenderer * chore: type cleanup * feat: added user data key for active cameras * feat: made renderer constructor params reactive * feat: made multiple cameras work * feat: made camera handling work properly and fixed event handler problem * feat: added option to set a camera active by it's uuid and the object itself * chore: moved composable to composables * chore: removed obsolete todo comments * chore: set antialias to be true by default in TresCanvas * chore: fix debugUI playground * chore: pnpm lock * chore: added localOrbitControls * chore: made render loop start initially * chore: changes concerning PR review * chore: changes concerning PR review * chore: remove camera test for now * chore: release v2.4.0-next.4 * chore: ci update for pnpm actions * chore: correct typo on test action name * chore: restored reactivity of renderer composable * chore: replaced userData handling in keys.ts by types * chore: made tests temporarily work * chore: disabled test temporarily * chore: removed readonly on scene for post-processing * chore: release v2.4.0-next.5 * chore: restored readonly on scene and removed it from renderer * chore: release v2.4.0-next.6 * chore: fixed hmr * chore: made usePointerEventHandler more uniform to other composables * feat: made renderer presets have less priority than explicitly defined props --------- Co-authored-by: Tino Koch <[email protected]> Co-authored-by: alvarosabu <[email protected]> * chore: release v2.4.0-next.7 * feat: remove readonly for scene on state context * chore: release v2.4.0-next.8 * feat: add defaults props for trescanvas to match renderer ones * chore: release v2.4.0-next.9 * feat: changed camera behavior so that the first added camera is always the active one * chore: release v2.4.0-next.10 * docs: updated docs concerning useTresContext composable * feat: added useTres alias for useTresContext * chore: changed useTresContext to useTres in the docs * chore: removed wrong dependency * fix: fixed issue caused by merge of main * chore: switched camera from ref to shallowRef * chore: removed obsolete comment * fix: revert shallorRef for cameras --------- Co-authored-by: Tino Koch <[email protected]> Co-authored-by: Tino Koch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.