Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 331 new context for state #333

Merged
merged 24 commits into from
Jul 29, 2023
Merged

Conversation

alvarosabu
Copy link
Member

Closes #331

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 2a0e72f
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/64c4d4586baaa900084110d5
😎 Deploy Preview https://deploy-preview-333--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu marked this pull request as draft July 4, 2023 07:45
alvarosabu and others added 10 commits July 4, 2023 09:51
* feat: refactored composables; seperated logic from TresCanvas

* chore: more changes concerning renderer composable

* feat: made window size reactive

* chore: made compasable params more uniform

* chore: refactored useRenderer

* chore: type cleanup

* feat: added user data key for active cameras

* feat: made renderer constructor params reactive

* feat: made multiple cameras work

* feat: made camera handling work properly and fixed event handler problem

* feat: added option to set a camera active by it's uuid and the object itself

* chore: moved composable to composables

* chore: removed obsolete todo comments

* chore: set antialias to be true by default in TresCanvas

* chore: fix debugUI playground

* chore: pnpm lock

* chore: added localOrbitControls

* chore: made render loop start initially

* chore: changes concerning PR review

* chore: changes concerning PR review

* chore: remove camera test for now

* chore: release v2.4.0-next.4

* chore: ci update for pnpm actions

* chore: correct typo on test action name

* chore: restored reactivity of renderer composable

* chore: replaced userData handling in keys.ts by types

* chore: made tests temporarily work

* chore: disabled test temporarily

* chore: removed readonly on scene for post-processing

* chore: release v2.4.0-next.5

* chore: restored readonly on scene and removed it from renderer

* chore: release v2.4.0-next.6

* chore: fixed hmr

* chore: made usePointerEventHandler more uniform to other composables

* feat: made renderer presets have less priority than explicitly defined props

---------

Co-authored-by: Tino Koch <[email protected]>
Co-authored-by: alvarosabu <[email protected]>
@alvarosabu alvarosabu marked this pull request as ready for review July 28, 2023 05:17
@alvarosabu
Copy link
Member Author

alvarosabu commented Jul 28, 2023

@Tinoooo I added an alias for useTresContext called useTres to:

  • Fix the issue with the docs build
  • Avoid having a BREAKING CHANGE that may confuse the user and would have to bump the version to 3.0 instead of 2.5 which is the one we want.

@Tinoooo
Copy link
Contributor

Tinoooo commented Jul 28, 2023

@Tinoooo I added an alias for useTresContext called useTres to:

  • Fix the issue with the docs build
  • Avoid having a BREAKING CHANGE that may confuse the user and would have to bump the version to 3.0 instead of 2.5 which is the one we want.

I like that. But the breaking change exists anyways, because the useTres now returns Refs instead of the objects themselves.

@alvarosabu alvarosabu merged commit 0e66f43 into main Jul 29, 2023
@Tinoooo Tinoooo deleted the feature/331-new-context-for-state branch September 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

New and better state context provider
2 participants