feat: removed useCamera logic from nodeOps
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
Tinoooo
reviewed
Jun 19, 2023
Co-authored-by: Tino Koch <[email protected]>
Co-authored-by: Tino Koch <[email protected]>
Tinoooo
approved these changes
Jun 19, 2023
…posable-from-nodeopts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue of the state being used on nodeOps. I removed the
useCameralogic from there.I also improved the error handling. If the user doesn't pass a camera via slots or props, a default
PerspectiveCamerawill be created.Closes #307
Closes #302
Closes #273