Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: raycaster does not work properly when scene is not in full screen #304

Merged
merged 21 commits into from
Jun 19, 2023
Merged

fix: raycaster does not work properly when scene is not in full screen #304

merged 21 commits into from
Jun 19, 2023

Conversation

Tinoooo
Copy link
Contributor

@Tinoooo Tinoooo commented Jun 16, 2023 •
edited
Loading

Fixes

  • Raycaster does not work properly when scene is not in full screen #282
  • pointerMove does now trigger only when the mouse actually moves, not on every requestAnimationFrame callback.
  • The click event behaves now just like in the DOM. That is only if pointerup fired on the same element as pointerdown did before. The click event used to fire in the same cases as pointerup would fire.

Breaking Changes

  • The pointerLeave event does not provide an intersection object, since leaving means no more intersection. 😄

Tinoooo and others added 16 commits June 1, 2023 14:21
@Tinoooo
chore: tinkering on possible solutions concerning pointer event handling
efcfcbf
@Tinoooo
chore: made click listeners work with changed architectures concernin…
bbd9fbe 
…g raycaster
@Tinoooo
chore: changed callback structure
06be907
@Tinoooo
chore: made pointer move work
62af8e0
@Tinoooo
chore: made other pointer events work
f069d36
@Tinoooo
chore: code cleanup
c8d32bd
@Tinoooo
chore: added deregistration of pointer event handlers for when an Oje…
d2cca14 
…ct3D is removed
@Tinoooo
chore: handled the case when the pointer leaves an Object3D but also …
ba9aedc 
…the canvas
@Tinoooo
Merge remote-tracking branch 'origin/main' into bugfix/282-raycaster-…
0625dda 
…does-not-work-properly-when-scene-is-not-in-full-screen
@Tinoooo
chore: replaced useRaycaster
d2ef57a
@alvarosabu
Merge branch 'main' into bugfix/282-raycaster-does-not-work-properly-…
27a774e 
…when-scene-is-not-in-full-screen
@Tinoooo
fix: raycaster works properly when scene does not take up the whole v…
a740a8e 
…iewport

fix: onPointerMove does not fire too often anymore
@Tinoooo
chore: made types in nodeOps a little more specific
11d5bff
@Tinoooo
chore: improved click event handling
8a4c3f4
@Tinoooo
docs: adjusted events page
d540591
@Tinoooo
chore: fixed typo
41a32b9
@Tinoooo Tinoooo linked an issue Jun 16, 2023 that may be closed by this pull request
Raycaster does not work properly when scene is not in full screen #282
Closed
5 tasks
@netlify
Copy link

netlify bot commented Jun 16, 2023 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 7766fce
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/648ff8959bbd9b0008bb4171
😎 Deploy Preview https://deploy-preview-304--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Tinoooo Tinoooo changed the title Bugfix/282 raycaster does not work properly when scene is not in full screen fix: raycaster does not work properly when scene is not in full screen Jun 16, 2023
@Tinoooo Tinoooo self-assigned this Jun 16, 2023
@Tinoooo Tinoooo added docs Improvements or additions to documentation core labels Jun 16, 2023
@Tinoooo Tinoooo marked this pull request as ready for review June 16, 2023 16:27
alvarosabu
alvarosabu approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @Tinoooo amazing work 👏🏻

@alvarosabu alvarosabu merged commit 20a5b9e into main Jun 19, 2023
@Tinoooo Tinoooo deleted the bugfix/282-raycaster-does-not-work-properly-when-scene-is-not-in-full-screen branch June 19, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

@JaimeTorrealba JaimeTorrealba Awaiting requested review from JaimeTorrealba

@userquin userquin Awaiting requested review from userquin

Assignees

@Tinoooo Tinoooo

Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raycaster does not work properly when scene is not in full screen
2 participants
@Tinoooo @alvarosabu