Skip to content

Commit b689c31

Browse files
Sub6ResourcesSub6Resources
committed
Refactor flutter_html_table
1 parent f076647 commit b689c31

File tree

8 files changed

+444
-262
lines changed

8 files changed

+444
-262
lines changed

‎example/lib/main.dart‎

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,18 @@ const htmlData = r"""
7676
</p>
7777
<table>
7878
<colgroup>
79-
<col width="50%" />
80-
<col span="2" width="25%" />
79+
<col width="200" />
80+
<col span="2" width="150" />
8181
</colgroup>
8282
<thead>
8383
<tr><th>One</th><th>Two</th><th>Three</th></tr>
8484
</thead>
8585
<tbody>
8686
<tr>
87-
<td rowspan='2'>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan</td><td>Data</td><td>Data</td>
87+
<td rowspan='2'>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan<br>Rowspan</td><td>Data</td><td>Data</td>
8888
</tr>
8989
<tr>
90-
<td colspan="2"><img alt='Google' src='https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_92x30dp.png' /></td>
90+
<td colspan="2"><img width="175" alt='xkcd' src='https://imgs.xkcd.com/comics/commemorative_plaque.png' /></td>
9191
</tr>
9292
</tbody>
9393
<tfoot>
@@ -135,7 +135,7 @@ const htmlData = r"""
135135
</p>
136136
<h3>Image support:</h3>
137137
<h3>Network png</h3>
138-
<img alt='Google' src='https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_92x30dp.png' />
138+
<img width="200" alt='xkcd' src='https://imgs.xkcd.com/comics/commemorative_plaque.png' />
139139
<h3>Network svg</h3>
140140
<img src='https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/android.svg' />
141141
<h3>Local asset png</h3>
@@ -154,7 +154,7 @@ const htmlData = r"""
154154
<img alt='No source' />
155155
<img alt='Empty source' src='' />
156156
<h3>Broken network image</h3>
157-
<img alt='Broken image' src='https://www.notgoogle.com/images/branding/googlelogo/2x/googlelogo_color_92x30dp.png' />
157+
<img alt='Broken image' src='https://www.example.com/images/branding/googlelogo/2x/googlelogo_color_92x30dp.png' />
158158
<h3>MathML Support:</h3>
159159
<math>
160160
<mrow>
@@ -281,29 +281,22 @@ class MyHomePageState extends State<MyHomePage> {
281281
"table": Style(
282282
backgroundColor: const Color.fromARGB(0x50, 0xee, 0xee, 0xee),
283283
),
284-
"tr": Style(
285-
border: const Border(bottom: BorderSide(color: Colors.grey)),
286-
),
287284
"th": Style(
288285
padding: const EdgeInsets.all(6),
289286
backgroundColor: Colors.grey,
290287
),
291288
"td": Style(
292289
padding: const EdgeInsets.all(6),
293-
alignment: Alignment.topLeft,
290+
border: const Border(bottom: BorderSide(color: Colors.grey)),
294291
),
295292
'h5': Style(maxLines: 2, textOverflow: TextOverflow.ellipsis),
296293
'flutter': Style(
297294
display: Display.block,
298295
fontSize: FontSize(5, Unit.em),
299296
),
300297
},
301-
tagsList: Html.tags..addAll(['tex', 'bird', 'flutter']),
298+
tagsList: Html.tags..addAll(['tex', 'bird', 'flutter', 'table', 'th', 'tr', 'td', 'colgroup', 'col', 'thead', 'tbody', 'tfoot']),
302299
extensions: [
303-
TagExtension(
304-
tagsToExtend: {"h4"},
305-
child: FlutterLogo(),
306-
),
307300
TagExtension(
308301
tagsToExtend: {"tex"},
309302
builder: (context) => Math.tex(
@@ -333,6 +326,7 @@ class MyHomePageState extends State<MyHomePage> {
333326
const AudioHtmlExtension(),
334327
const VideoHtmlExtension(),
335328
const IframeHtmlExtension(),
329+
const TableHtmlExtension(),
336330
],
337331
// customRenders: {
338332
// tagMatcher("table"): CustomRender.widget(

‎lib/src/builtins/vertical_align_builtin.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ class VerticalAlignBuiltIn extends Extension {
1818
@override
1919
bool matches(ExtensionContext context) {
2020
return context.styledElement?.style.verticalAlign != null &&
21-
context.styledElement!.style.verticalAlign != VerticalAlign.baseline;
21+
(context.styledElement!.style.verticalAlign == VerticalAlign.sub
22+
|| context.styledElement!.style.verticalAlign == VerticalAlign.sup);
2223
}
2324

2425
@override

‎lib/src/style.dart‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -681,6 +681,9 @@ enum VerticalAlign {
681681
baseline,
682682
sub,
683683
sup,
684+
top,
685+
bottom,
686+
middle,
684687
}
685688

686689
enum WhiteSpace {

‎packages/flutter_html_iframe/lib/flutter_html_iframe.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class IframeHtmlExtension extends Extension {
2323
InlineSpan parse(ExtensionContext context, parseChildren) {
2424
return WidgetSpan(
2525
child: IframeWidget(
26+
extensionContext: context,
2627
navigationDelegate: navigationDelegate,
2728
),
2829
);

‎packages/flutter_html_iframe/lib/iframe_unsupported.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import 'package:flutter/material.dart';
2+
import 'package:flutter_html/flutter_html.dart';
23
import 'package:webview_flutter/webview_flutter.dart';
34

45
class IframeWidget extends StatelessWidget {
56

67
const IframeWidget({
78
Key? key,
9+
required ExtensionContext? extensionContext,
810
NavigationDelegate? navigationDelegate,
911
}) : super(key: key);
1012

0 commit comments

Comments
 (0)