Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres build status #36

Open
shawnlaffan opened this issue Feb 16, 2023 · 3 comments
Open

postgres build status #36

shawnlaffan opened this issue Feb 16, 2023 · 3 comments
Assignees
@shawnlaffan

Comments

@shawnlaffan
Copy link
Contributor

shawnlaffan commented Feb 16, 2023 •
edited
Loading

It seems I have not been checking the postgresql builds.

Running a new build and re-using build artifacts from a previous run to speed things up, I get these failures.

### BUILDING postgresql-15.1
cp: cannot stat 'src/interfaces/libpq/libpqdll.def': No such file or directory
sed: can't read src/interfaces/libpq/libpqdll.def.old: No such file or directory

...more logging...

checking for library containing gethostbyname_r... no
checking for library containing pthread_barrier_wait... none required
checking for inflate in -lz... no
configure: error: zlib library not found
If you have zlib already installed, see config.log for details on the
failure.  It is possible the compiler isn't looking in the proper directory.
Use --without-zlib to disable zlib support.

There are no patches for postgres 15.1 at the moment (edit - in this repo). MSYS are applying a number of patches which we should look to adapt. Some are already present for postgres 9.x but since we use version specific patch sets they are not applied.

MSYS also disable the perl component in their build, which maybe we should look at if it has no effect on Strawberry perl users and if postgres does a hard bind to the version it was built with.
@shawnlaffan shawnlaffan self-assigned this Feb 16, 2023
@shawnlaffan shawnlaffan mentioned this issue Feb 18, 2023
Open
@shawnlaffan
Copy link
Contributor Author

These errors could also just be the way I set up the build. Postgres is listed as building successfully in #4 (comment)

The MSYS patches will probably still be useful though.

@shawnlaffan
Copy link
Contributor Author

The build errors were a PEBKAC as I neglected to pass the DLLSUFFIX argument to the build.sh call.

I'll leave this open as I suspect the patches will still be useful.

@shawnlaffan shawnlaffan mentioned this issue Feb 18, 2023
Closed
@shawnlaffan
Copy link
Contributor Author

I need to look a bit further but perl is needed for two Postgres components.

The build for the latter includes XS code so will need to be run with the same perl it was built with (https://github.com/postgres/postgres/tree/master/src/pl/plperl). If it is enabled the docker image needs an initial perl build to bootstrap itself, consistent with the current diagram (StrawberryPerl/spbuild#12).

FWIW, MSYS2/mingw disable it in their builds.
https://github.com/msys2/MINGW-packages/blob/42c31ba612a436c4fe3fccce6bdefc934a069fc3/mingw-w64-postgresql/PKGBUILD#L94

Is PL/perl used by consumers of strawberry perl? Has it worked in the past few versions of strawberry perl? Have the past few versions even included it?

@shawnlaffan shawnlaffan mentioned this issue May 9, 2024
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnlaffan