-[xcode]: revert enabling debug dylib support for widgets #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahee96
requested review from
JoeMatt,
Spidy123222,
SternXD,
lonkelle and
nythepegasus
as code owners
|
Builds for this Pull Request are available at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For Xcode 16+ Apple had enabled "Debug Dylib" generation which contains most of the business logic while executable being the stub to handover control on entry to the app.
This is required to be enabled mandatorily for "previews" generation in Xcode 16+.
Debug dylib and previews were reportedly having issues and/or is broken.
Since Widgets were supposed to be isolated than main app it was enabled in the commit 2842c8f.
Changes
Some users have reported after the widgets fix in 2842c8f, sidestore crashes when trying to open.
Possible suspect is "Debug Dylib Support" for previews throwing "No Entry Point found" but not sure.
So we are disabling it in CI builds as before the widgets fix where the users had confirmed it was working fine.