forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 11
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: SUSE/stratos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.4.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: SUSE/stratos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.4.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 7 files changed
- 2 contributors
Commits on Nov 22, 2022
-
Fix application of
maxedlists following page refreshIssue - When there are too many resources to show in a list we enter `max` state - When in max'd state we force the user to select filters to restrict the number of results (changing filters results in new https requests containing those filters) - We persist the state of the list to local storage. This includes filters but does not include the `max` flag - When the user re-vists the list after page refresh instead of fetching all resources we only fetch those applicable to the filter (which will be a small subset of all resources). As the `max` flag isn't there we assume we've fetched all resources. Any changes to the filter are then applied locally to the subset of resources... which won't contain any from the new filter Fix - Persist the list's `max` state such that when the list loads again all filter changes correctly result in http requests - This needed a fix in the way we watch the filters for changes (we block this watch until all filters report as ready) - Fix downside - Lists cannot ever leave the `max` state. All changes to filters will result in http requests. User would need to clear their local cache to reset the list (we have a button for this in the user's profile page) Tested - Different types of org/space filter setups - orgs with no spaces - orgs with some spaces under maxed, some over - Different types of lists - Tested with UI_LIST_ALLOW_LOAD_MAXED true (allow user to overrule maxed state and fetch everything)
Configuration menu - View commit details
-
Copy full SHA for 0dfedbc - Browse repository at this point
Copy the full SHA 0dfedbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a277791 - Browse repository at this point
Copy the full SHA a277791View commit details
Commits on Nov 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 69f6a91 - Browse repository at this point
Copy the full SHA 69f6a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1879481 - Browse repository at this point
Copy the full SHA 1879481View commit details -
Merge pull request #559 from SUSE/fix-refresh-maxed-list
Fix application of `maxed` lists following page refresh
Configuration menu - View commit details
-
Copy full SHA for 06242a6 - Browse repository at this point
Copy the full SHA 06242a6View commit details -
Merge pull request #561 from SUSE/bump-version-4.4.5
Bump versions from 4.4.4 to 4.4.5, add to changelog
Configuration menu - View commit details
-
Copy full SHA for d32e3f2 - Browse repository at this point
Copy the full SHA d32e3f2View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.4.4...4.4.5