fix(ui5-badge): correct hover background color for Set 2 Color Scheme 9 #10233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LidiyaGeorgieva
left a comment
LidiyaGeorgieva
left a comment
There was a problem hiding this comment.
The comment for ui5-tag pull request is valid also here ("For horizon_dark maybe the parameters should be added also? Hover looks OK, but active - not.")
Maybe some parameter value is wrong?
Contributor
Author
|
Active styles will be fixed with another PR. |
LidiyaGeorgieva
approved these changes
Nov 27, 2024
nnaydenow
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #10164
downport of #10229