fix(ui5-rating-indicator): outline border is visible when focus #10205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoplashkov
requested changes
Nov 20, 2024
packages/main/src/themes/sap_horizon/RatingIndicator-parameters.css
Outdated
Show resolved
Hide resolved
ivoplashkov
requested changes
Nov 20, 2024
Contributor
ivoplashkov
left a comment
ivoplashkov
left a comment
There was a problem hiding this comment.
The issue is still reproducible for the following themes:
- sap_horizon_dark
- sap_horizon_hcb
- sap_horizon_hcw
ivoplashkov
approved these changes
Dec 3, 2024
Collaborator
|
🎉 This PR is included in version v2.5.0-rc.3 🎉 The release is available on v2.5.0-rc.3 Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #10162
The solution: made the "--_ui5_rating_indicator_outline_offset" parameter negative value, so now it can be seen when the rating indicator is focused. Added padding parameter, so the stars of the indicator are not touching the edges of the focus. Made the "--_ui5_rating_indicator_border_radius" parameter bigger.