feat(ui5-ainotice): introduce new component #10169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If it's an "ai" component, shouldn't it be added in the "ai" package? |
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
| @@ -0,0 +1,6 @@ | |||
| .verificationText { | |||
Contributor
There was a problem hiding this comment.
we have convention for class names - look some of the existing compoenents
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
reviewed
Nov 13, 2024
ilhan007
requested changes
Nov 13, 2024
Contributor
ilhan007
left a comment
ilhan007
left a comment
There was a problem hiding this comment.
There are some points for improvements - posted inline.
elenastoyanovaa
requested changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.