fix(ui5-list): enable focusin event bubbling #10156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NakataCode
force-pushed
the
list-focus-bubbling
branch
from
b9b47d5 to
26f268d
Compare
TeodorTaushanov
approved these changes
Nov 27, 2024
nnaydenow
reviewed
Nov 28, 2024
Collaborator
|
🎉 This PR is included in version v2.5.0-rc.3 🎉 The release is available on v2.5.0-rc.3 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The focusin event was being stopped with e.stopImmediatePropagation() if it didn’t originate from specific trigger elements, preventing the event from bubbling and limiting focus tracking at the parent level.
Solution:
Removed e.stopImmediatePropagation() in cases where the event source is outside trigger elements, allowing the focusin event to bubble as expected.
Fixes: #9787