Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update list of deprecated libs #42

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix: Update list of deprecated libs #42

merged 3 commits into from
Mar 22, 2024

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Mar 21, 2024

  • Sort entries
  • Remove non-existent sap.dragonfly
  • Fix typo for sap.landvisz
  • Add missing sap.sac.grid

@matz3
fix: Update list of deprecated libs
5807c4e 
- Sort entries
- Remove non-existent sap.dragonfly
- Fix typo for sap.landvisz
- Add missing sap.sac.grid
@codeworrior
Copy link
Member

Sorry, I think I had mixed up sap.sac.df (dragonfly - still exists) and sap.sac.grid (deprecated and removed after 1.113)

codeworrior
codeworrior previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 marked this pull request as ready for review March 21, 2024 08:19
@matz3 matz3 requested a review from a team March 21, 2024 08:19
codeworrior
codeworrior previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't judge whether the 2 bytes in the snapshot file are okay, but otherwise the change LGTM.

@RandomByte
Copy link
Member

What about sap.fe.common and sap.fe.semantics (both removed after 1.108 and 1.102 respectively)?

@matz3 matz3 merged commit d38e356 into main Mar 22, 2024
7 checks passed
@matz3 matz3 deleted the update-deprecated-libs branch March 22, 2024 08:45
@openui5bot openui5bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@codeworrior codeworrior codeworrior left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matz3 @codeworrior @RandomByte @maxreichmann