Skip to content

deps: Bump eslint from 8.57.0 to 9.8.0 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024
Merged

deps: Bump eslint from 8.57.0 to 9.8.0 #230

merged 4 commits into from
Aug 2, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Jul 31, 2024

JIRA: CPOUI5FOUNDATION-827

Note:

In order to support TS eslint checks, this repo depends not only on EsLint, but also on complementary dependencies: typescript-eslint & @stylistic/eslint-plugin. In order to meet their peerDependency requirements for ESLint 9, those modules need to get alpha & beta releases:

  • "typescript-eslint": "8.0.0-alpha.60"
  • "@stylistic/eslint-plugin": "2.6.0-beta.1"

More details: typescript-eslint/typescript-eslint#8211

Edit: typescript-eslint & @stylistic/eslint-plugin have been released and the automatic bumps would be suppressed and integrated within this change: #231 #234

@d3xter666
Copy link
Contributor Author

d3xter666 commented Jul 31, 2024

Please take a look at the description box above.
We might block the merge of that one until typescript-eslint & @stylistic/eslint-plugin get their stable versions.

matz3
matz3 previously approved these changes Aug 1, 2024
@d3xter666 d3xter666 merged commit 9e80d2f into main Aug 2, 2024
13 checks passed
@d3xter666 d3xter666 deleted the bump-eslint-9.8.0 branch August 2, 2024 10:23
@openui5bot openui5bot mentioned this pull request Aug 2, 2024
d3xter666 added a commit that referenced this pull request Aug 12, 2024
With the introduction of ESLint 9 and the update of `typescript-eslint`,
there are new rules that will be applied to the code. Those rules are
mainly focused on Regex patterns.

With #230 those rules have been
turned off to keep it consistent with the old behavior.
This change aims to enable those rules.

**Note:** The base for this change is
#230 and not the **main** branch.
This way it's clearer what the real changes are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants