Skip to content

PoC: Streaming Spec Update #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatKuhr wants to merge 2 commits into from
Closed

PoC: Streaming Spec Update #283

MatKuhr wants to merge 2 commits into from

Conversation

@MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Nov 11, 2024 •
edited
Loading

Testing a potential spec change for orchestration to fix the streaming inconsistency.

Before:

const choices: LlmChoice[] = result.data.orchestration_result.choices;

Type 'LlmChoice[] | LLMChoiceStreaming[]' is not assignable to type 'LlmChoice[]'.

After:
The above code now works 😉

@MatKuhr MatKuhr marked this pull request as draft November 11, 2024 16:44
@MatKuhr MatKuhr closed this Dec 19, 2024
@MatKuhr MatKuhr deleted the streaming-spec-change branch December 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatKuhr