Skip to content

feat: Add signature checks #337

Open
@oSumAtrIX

Description

@oSumAtrIX

Feature description

Depends on ReVanced/revanced-library#61

A signature should accompany each patch file. This can be achieved via an ArgGroup. The current patch file option can be moved into an arg group accompanied by an optional signature option. The keyring can be supplied via an option next to the ArgGroug. If the signature is missing or invalid, the patch should abort. Another option can be added to skip signature checks. A warning should always be shown if the signature check failed or was skipped. Example:

java -jar cli.jar patch -b patches.rvp -s patches.rvp.asc -b patches2.rvp -k revanced.gpg

A new utility subcommand should be added regarding the signatures.

Motivation

Same as ReVanced/revanced-manager#2082

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions