Merge 2.3.x in main #8064
Merged
Merge 2.3.x in main #8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vladimir Vlasov <[email protected]>
Docs review Co-authored-by: Akela Drissner-Schmid <[email protected]>
Add warnings for wrong values of model_confidence parameter
prepared release of version 2.3.4
dakshvar22
requested review from
a team and
wochinge
and removed request for
a team
wochinge
approved these changes
Feb 26, 2021
* Updated 2.X changelog to include 1.10.23 update * Update 2.3.X changelog.mdx * Updated link formatting * Update CHANGELOG.mdx Co-authored-by: Tobias Wochinger <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]>
|
Opening another PR to fix it |
|
😂 I needed something from that branch - and it was approved + green so = 🤷. Sorry, it wasn't obvious that this PR wasn't ready yet |
|
definitely not on you, Daksh requested help from engineering to merge this on Friday, the integration tests were not passing (actually were flaky). Fixed it in #8094 |
|
thanks a lot for jumping on a fix 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)