Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GooglePlayStoreBridge] Add bridge #2110

Merged
merged 3 commits into from
Feb 12, 2022
Merged

[GooglePlayStoreBridge] Add bridge #2110

merged 3 commits into from
Feb 12, 2022

Conversation

yamanq
Copy link
Contributor

@yamanq yamanq commented May 9, 2021

Google Play does not have a changelog with history, but this bridge returns the most recent version which RSS readers can then accumulate.

Resolves #1352

@yamanq yamanq force-pushed the yamanq/gps_bridge branch from 74b6486 to 8d8b7ed Compare May 9, 2021 23:18
@dvikan
Copy link
Contributor

dvikan commented Nov 29, 2021

Tested locally and it works. But im getting these errors:

Notice: Undefined index: Size in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Installs in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Requires Android in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Content Rating in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Interactive Elements in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: In-app Products in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Permissions in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Report in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

Notice: Undefined index: Developer in /home/rssbridge/public/bridges/GooglePlayStoreBridge.php on line 33

I understand the motivation for this bridge. However since it always returns one feed item, I feel it's more appropriate to use a change detection service for this.

em92
em92 suggested changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @dvikan mentioned, please fix notices.
https://feed.eugenemolotov.ru/pr2110/?action=display&bridge=GooglePlayStore&id=com.ichi2.anki&format=Html

bridges/GooglePlayStoreBridge.php Outdated Show resolved Hide resolved
@yamanq
Copy link
Contributor Author

yamanq commented Feb 10, 2022

Thank you for the reviews @dvikan @em92

I fixed both issues and added detectParameters.

@yamanq yamanq requested a review from em92 February 10, 2022 05:34
@em92 em92 merged commit 8723647 into RSS-Bridge:master Feb 12, 2022
@em92
Copy link
Contributor

em92 commented Feb 12, 2022

gj!

Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
@yamanq @Kwbmm
[GooglePlayStoreBridge] Add bridge (RSS-Bridge#2110)
4dbb07a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em92 em92 Awaiting requested review from em92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bridge request for Google Play Store
3 participants
@yamanq @dvikan @em92