Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QIICR/dcmqi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.2
Choose a base ref
...
head repository: QIICR/dcmqi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.3
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on May 30, 2024

  1. mention pip install dcmqi

    @fedorov
    fedorov authored May 30, 2024
    Configuration menu
    Copy the full SHA
    1f0ae64 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. bug: switch to integer for the skip flag 

    re #498

It appears that defaults are ignored for boolean SEM parameters. Even though
the parameter was set to true in https://github.com/QIICR/dcmqi/blob/2990dbd01d1fa61c16777950732ff19dc87318e3/apps/seg/itkimage2segimage.xml#L58-L65,
the default reported by the executable was 0.

Local tests show that integer parameters do not have this problem.

Also switch to the most recent has for SlicerExecutionModel.
    @fedorov
    fedorov committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4d5ba16 View commit details
    Browse the repository at this point in the history

  2. test: update test to account for changed behavior of the parameter

    @fedorov
    fedorov committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    bc19b0d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #499 from QIICR/498-fix-skip-option 

    bug: switch to integer for the skip flag
    @fedorov
    fedorov authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2d92484 View commit details
    Browse the repository at this point in the history

  4. cmake: set version to 1.3.3

    @fedorov
    fedorov committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    81e9073 View commit details
    Browse the repository at this point in the history
Loading