-
Notifications
You must be signed in to change notification settings - Fork 61
Comparing changes
Open a pull request
base repository: QIICR/dcmqi
base: v1.3.0
head repository: QIICR/dcmqi
compare: v1.3.1
- 20 commits
- 24 files changed
- 2 contributors
Commits on Dec 5, 2023
-
Ensure to also handle more than 65535 frames.
In order to make the class more generic, also handle more than 65535 frames (Number of Frames can be 2^32-1 max).
Configuration menu - View commit details
-
Copy full SHA for 5a9cc2f - Browse repository at this point
Copy the full SHA 5a9cc2fView commit details -
Remember frame positions in Result, small changes.
Also remember frame positions in sorting result since it is usually accessed anyway and interesting for library users that otherwise call the underlying method on FGInterface for all frames again. The DummySorter does not provide frame positions to keep it as simple as possible (i.e. keep it "zero" cost). Allow 2^32-1 frames as permitted in in DICOM (i.e. use Uint32 instead of Uint16) for frame number index. Changed precision from Float32 to Float64 where applicable. Added some documentation.
Configuration menu - View commit details
-
Copy full SHA for 05b36fb - Browse repository at this point
Copy the full SHA 05b36fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3614ed3 - Browse repository at this point
Copy the full SHA 3614ed3View commit details
Commits on Dec 6, 2023
-
Merge pull request #484 from michaelonken/switch_to_framesorter_class
Switch to framesorter class
Configuration menu - View commit details
-
Copy full SHA for c9738ca - Browse repository at this point
Copy the full SHA c9738caView commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 107c359 - Browse repository at this point
Copy the full SHA 107c359View commit details -
Make sure input data has been initialized by user before public methods are called. Made logging message more consistent. Made code more readable.
Configuration menu - View commit details
-
Copy full SHA for cee108c - Browse repository at this point
Copy the full SHA cee108cView commit details
Commits on Dec 8, 2023
-
Use Label IDs as Segment Numbers.
When converting from ITK to DICOM, allow to use Label IDs as Segment Numbers so that even if reading from various NRRD inputs, the Segments in the DICOM file will still use the Label IDs from the NRRD files. This is particularly helpful for testing since it allows a roundtrip test from DICOM -> multiple NRRD files using potentially multiple segments each -> back to DICOM. If no mapping to the Label IDs takes place, the converter will use ascending Segment Numbers, so the order will depend on the read order, which again usually depends on the order in the JSON meta information. This sorting behavior is disabled by default. It is available as cli option (--sortByLabelID) which is handed to the library through the Itk2DicomConverter::itkimage2dcmSegmentation() call.
Configuration menu - View commit details
-
Copy full SHA for 08a5ebd - Browse repository at this point
Copy the full SHA 08a5ebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d2bbb3 - Browse repository at this point
Copy the full SHA 4d2bbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 181d3e2 - Browse repository at this point
Copy the full SHA 181d3e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3576a86 - Browse repository at this point
Copy the full SHA 3576a86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4747eed - Browse repository at this point
Copy the full SHA 4747eedView commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4f98007 - Browse repository at this point
Copy the full SHA 4f98007View commit details
Commits on Dec 18, 2023
-
Renamed feature from sortByLabel to useLabelIDAsSegmentNumber. Added check for unique, monotonically increasing label IDs before starting reassignment. Added missing update of ReferencedFrameNumber.
Configuration menu - View commit details
-
Copy full SHA for a4b433a - Browse repository at this point
Copy the full SHA a4b433aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2990dbd - Browse repository at this point
Copy the full SHA 2990dbdView commit details -
Merge pull request #485 from michaelonken/use_label_id_as_segment_num…
…bers Use labelIDs as segment numbers
Configuration menu - View commit details
-
Copy full SHA for a7cb0f7 - Browse repository at this point
Copy the full SHA a7cb0f7View commit details -
Fix order of pixel spacing converting ITK->DICOM.
The order in which the values for pixel spacing in ITK and DICOM are stored is different. In DICOM the first value is the row spacing (i.e. Y axis) while in ITK the first value is spacing along the X axis. Reading asymmetric spacings from DICOM segmentations has already been fixed in 46c6f0. This commit fixes writing DICOM segmentation objects with asymmetric spacings.
Configuration menu - View commit details
-
Copy full SHA for d679c2c - Browse repository at this point
Copy the full SHA d679c2cView commit details -
Merge pull request #486 from michaelonken/fix_issue_473_asymmetric_pi…
…xel_spacing Fix order of pixel spacing converting ITK->DICOM.
Configuration menu - View commit details
-
Copy full SHA for ad0e09f - Browse repository at this point
Copy the full SHA ad0e09fView commit details
Commits on Jan 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 563b530 - Browse repository at this point
Copy the full SHA 563b530View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4cfecc - Browse repository at this point
Copy the full SHA a4cfeccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1922a09 - Browse repository at this point
Copy the full SHA 1922a09View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.3.0...v1.3.1