Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QIICR/dcmqi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Choose a base ref
...
head repository: QIICR/dcmqi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.1
Choose a head ref
  • 20 commits
  • 24 files changed
  • 2 contributors

Commits on Dec 5, 2023

  1. Ensure to also handle more than 65535 frames.

    In order to make the class more generic, also handle more than 65535
    frames (Number of Frames can be 2^32-1 max).
    michaelonken committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5a9cc2f View commit details
    Browse the repository at this point in the history
  2. Remember frame positions in Result, small changes.

    Also remember frame positions in sorting result since it is usually
    accessed anyway and interesting for library users that otherwise call
    the underlying method on FGInterface for all frames again.
    
    The DummySorter does not provide frame positions to keep it as simple
    as possible (i.e. keep  it "zero" cost).
    
    Allow 2^32-1 frames as permitted in in DICOM (i.e. use Uint32 instead
    of  Uint16) for frame number index.
    
    Changed precision from Float32 to Float64 where applicable.
    
    Added some documentation.
    michaelonken committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    05b36fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3614ed3 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge pull request #484 from michaelonken/switch_to_framesorter_class

    Switch to framesorter class
    fedorov authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c9738ca View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Configuration menu
    Copy the full SHA
    107c359 View commit details
    Browse the repository at this point in the history
  2. Various small enhancements.

    Make sure input data has been  initialized  by user before public
    methods are called.
    
    Made logging message more consistent.
    
    Made code more readable.
    michaelonken committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    cee108c View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Use Label IDs as Segment Numbers.

    When converting from ITK to DICOM, allow to use Label IDs as Segment
    Numbers so that even if reading from various NRRD inputs, the Segments
    in the DICOM file will still use the Label IDs from the NRRD files.
    
    This is particularly helpful for testing since it allows a roundtrip test
    from DICOM -> multiple NRRD files using potentially multiple segments
    each -> back to DICOM. If no mapping to the Label IDs takes place, the
    converter will use ascending Segment Numbers, so the order will depend
    on the read order, which again usually depends on the order in the JSON
    meta information.
    
    This sorting behavior is disabled by default. It is available as
    cli option (--sortByLabelID) which is handed to the library through the
    Itk2DicomConverter::itkimage2dcmSegmentation() call.
    michaelonken committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    08a5ebd View commit details
    Browse the repository at this point in the history
  2. Added documentation.

    michaelonken committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4d2bbb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    181d3e2 View commit details
    Browse the repository at this point in the history
  4. Fixed typos.

    michaelonken committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3576a86 View commit details
    Browse the repository at this point in the history
  5. Try to fix docker test.

    Added missing test dependency.
    michaelonken committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4747eed View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    4f98007 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Fixing/enhancing this PR.

    Renamed feature from sortByLabel to useLabelIDAsSegmentNumber.
    Added check for unique, monotonically increasing label IDs before
    starting reassignment.
    Added missing update of ReferencedFrameNumber.
    michaelonken committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a4b433a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2990dbd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #485 from michaelonken/use_label_id_as_segment_num…

    …bers
    
    Use labelIDs as segment numbers
    fedorov authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a7cb0f7 View commit details
    Browse the repository at this point in the history
  4. Fix order of pixel spacing converting ITK->DICOM.

    The order in which the values for pixel spacing in ITK and DICOM are
    stored is different. In DICOM the first value is the row spacing
    (i.e. Y axis) while in ITK the first value is spacing along the X axis.
    
    Reading asymmetric spacings from DICOM segmentations has already been
    fixed in 46c6f0.
    
    This commit fixes writing DICOM segmentation objects with asymmetric
    spacings.
    michaelonken committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d679c2c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #486 from michaelonken/fix_issue_473_asymmetric_pi…

    …xel_spacing
    
    Fix order of pixel spacing converting ITK->DICOM.
    fedorov authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ad0e09f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. fix destination for docker images publishing

    aims to resolve #487
    fedorov authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    563b530 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. fix ORG for docker build

    Re #487 thanks to @michaelonken!
    fedorov authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a4cfecc View commit details
    Browse the repository at this point in the history
  2. cmake: set version to 1.3.1

    fedorov committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1922a09 View commit details
    Browse the repository at this point in the history
Loading