Add R2 score to metrics #8093
Open
Add R2 score to metrics #8093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
|
/build |
|
hi @KumoLiu, could you please have a look at this PR? |
KumoLiu
reviewed
Oct 22, 2024
| from monai.handlers import R2Score | ||
|
|
||
|
|
||
| class TestHandlerR2Score(unittest.TestCase): |
There was a problem hiding this comment.
Base on the ci :https://github.com/Project-MONAI/MONAI/actions/runs/10926409391/job/30330218578?pr=8093#step:8:13844
You need skip the tests if no ignite installed.
| def _calculate(y_pred: np.ndarray, y: np.ndarray, p: int) -> float: | ||
| num_obs = len(y) | ||
| rss = np.sum((y_pred - y) ** 2) | ||
| tss = np.sum(y**2) - np.sum(y) ** 2 / num_obs |
There was a problem hiding this comment.
Should be tss = np.sum((y - np.mean(y)) ** 2) here?
ericspod
reviewed
Oct 22, 2024
|
|
||
| class R2Score(IgniteMetricHandler): | ||
| """ | ||
| Computes :math:`R^{2}` score accumulating predictions and the ground-truth during an epoch and applying `compute_r2_score`. |
There was a problem hiding this comment.
As elsewhere it would help to explain where this is used and what it would be for. The math is explained in the function which is fine so no need here, just a high level idea.
ericspod
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Also here if possible to combine this file with the previous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8085.
Description
I created:
R2Metricandcompute_r2_scoreinmonai.metrics,R2Scoreinmonai.handlers,test_compute_r2_score.py,test_handler_r2_score.pyandtest_handler_r2_score_dist.py.I also modified the docs to mention R2 score.
Note:
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.