Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differential Flow #2260

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Conversation

ejohnson-96
Copy link
Contributor

Description

Addition of the differential flow functionality to the collisional analysis module. The update also contains the respective notebook.

Motivation and context

The motivation is to build up the collisions subpackage in plasmapy, specifically adding the collisional analysis functionality.

Related issues

@ejohnson-96 ejohnson-96 requested a review from a team as a code owner July 31, 2023 18:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org plasmapy.formulary Related to the plasmapy.formulary subpackage notebooks Related to example Jupyter notebooks in docs/examples/ labels Jul 31, 2023
@github-actions
Copy link

Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱

Our contributor guide has information on:

The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:

  • Try fixing CI / Python 3.11 test failures first.
  • Most pre-commit.ci - pr failures can be automagically fixed by commenting pre-commit.ci autofix below, followed by a git pull to bring the changes back to your computer.
  • If pre-commit.ci - pr says that a function is too long or complex, try breaking up that function into multiple short functions that each do one thing. See also these tips on writing clean scientific software.
  • If the CI / Documentation check ends with a cryptic error message, check out our documentation troubleshooting guide.
  • For a documentation preview, click on Details next to docs/readthedocs.org:plasmapy.

If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder.

Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples.

We thank you once again!

@ejohnson-96 ejohnson-96 marked this pull request as draft July 31, 2023 19:41
@ejohnson-96 ejohnson-96 removed the request for review from pheuer July 31, 2023 19:42
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 84.70% and project coverage change: -0.14% ⚠️

Comparison is base (6332fb8) 98.37% compared to head (3eadfb3) 98.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   98.37%   98.23%   -0.14%     
==========================================
  Files          98       98              
  Lines        8533     8599      +66     
==========================================
+ Hits         8394     8447      +53     
- Misses        139      152      +13     
Files Changed Coverage Δ
...formulary/collisions/helio/collisional_analysis.py 87.50% <84.33%> (-7.67%) ⬇️
plasmapy/formulary/collisions/helio/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added requirements Related to updating requirements packaging Related to packaging or distribution labels Aug 2, 2023
@namurphy namurphy added this to the Future milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/ packaging Related to packaging or distribution plasmapy.formulary Related to the plasmapy.formulary subpackage requirements Related to updating requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants