Add basic comments support to the AST #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the Recast comment-attachment structure[0], though only
implements a small subset in a straightforwardly hacky manner, and
does not come close to implementing the entire comment-attachment
structure or algorithm:
* comments preceding (some) nodes are extracted and set on the
`comments` key of the host node
* does not extract the location
* only does leading comments (I don't think it'll mis-attach trailing
comments but that's not impossible)
* may not work for all node types
* the comments key may be missing entirely
* uses esprima's type (Block/Line) rather than Babel's
[0] dev's reasoning about some comments being ambiguous in Esprima's
structure/extension makes sense to me:
jquery/esprima#1024 (comment)
benjamn/recast#159 (comment)
|
Thank you very much! Seems to work for now. Maybe I will update the pyesprima according to the newest esprima.js version if I find some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf #14
Follows the Recast comment-attachment structure[0], though only implements a small subset in a straightforwardly hacky manner, and does not come close to implementing the entire comment-attachment structure or algorithm:
commentskey of the host nodecomments but that's not impossible)
[0] dev's reasoning about some comments being ambiguous in Esprima's structure/extension makes sense to me: jquery/esprima#1024 (comment) benjamn/recast#159 (comment)