Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra handle passed to kernel_api() #429

Closed
wibeasley opened this issue Sep 26, 2022 · 6 comments · Fixed by #432
Closed

extra handle passed to kernel_api() #429

wibeasley opened this issue Sep 26, 2022 · 6 comments · Fixed by #432
Assignees
@wibeasley

Comments

@wibeasley
Copy link
Member

suggested by @brandonpotvin in a meeting after REDCapCon
@wibeasley wibeasley self-assigned this Sep 26, 2022
wibeasley added a commit that referenced this issue Sep 26, 2022
@wibeasley
experimenting w/ CDC handle
b259a5b 
ref #429
wibeasley added a commit that referenced this issue Sep 26, 2022
@wibeasley
"form" encode
4526179 
@brandonpotvin, will you try it now that the `encode` parameter is set "form".  I'm not optimistic.

ref #429
wibeasley added a commit that referenced this issue Sep 26, 2022
@wibeasley
parameterize encoding and handle passed to httr::POST()
12002e6 
@brandonpotvin, glad the last one worked.  Love to be wrong.
 Will you give this commit a shot?  Notice I renamed to `handle_httr` and also added `encode_httr` that you should set to "form".

ref #429
wibeasley added a commit that referenced this issue Sep 27, 2022
@wibeasley
hardcode encode_httr in kernel_api()
84d28d0 
ref #429
@wibeasley
Copy link
Member Author

@brandonpotvin, will you please test these functions in the "cdc-handle" branch? If they work, I'll add the handle_httr to the other ~30 functions

  • redcap_metadata_read()
  • redcap_read()
  • redcap_read_oneshot()

Note to self:

I was surprised that this worked because I think it's essentially the same as the version that failed when we were on this morning's call.
12002e6#commitcomment-85076424

Working backward, the only changes were b259a5b & 4526179

Basically all I've ultimately changed to httr::POST()'s encode parameter is hardcoding it to "multipart", which is the default anyway. Maybe I misunderstood during our rushed debugging session and the problem was something else.

@brandonpotvin
Copy link

@wibeasley all three functions below are working as expected.
redcap_metadata_read()
redcap_read()
redcap_read_oneshot()

@wibeasley
Copy link
Member Author

wibeasley commented Sep 27, 2022 •
edited
Loading

  • redcap_read()
  • redcap_read_oneshot()
  • redcap_read_oneshot_eav()
  • redcap_write()
  • redcap_write_oneshot()
  • redcap_delete()
  • redcap_report()
  • redcap_download_file_oneshot()
  • redcap_upload_file_oneshot()
  • redcap_arm_export()
  • redcap_dag_read()
  • redcap_download_instrument()
  • redcap_event_instruments()
  • redcap_instruments()
  • redcap_log_read()
  • redcap_metadata_coltypes()
  • redcap_metadata_read()
  • redcap_metadata_write()
  • redcap_next_free_record_name()
  • redcap_project_info_read()
  • redcap_survey_link_export_oneshot()
  • redcap_users_export()
  • redcap_variables()
  • redcap_version()

wibeasley added a commit that referenced this issue Sep 27, 2022
@wibeasley
handle for all the record-related calls
4bd5bd8 
and some other functions that they call

ref #429
wibeasley added a commit that referenced this issue Sep 28, 2022
@wibeasley
handle for the rest of the function
2c374a6 
ref #429
@wibeasley
Copy link
Member Author

@brandonpotvin, I've finished adding this parameter to all the functions (and its connection to kernel_api()). All the existing tests still pass, but of course I can't replicate your institution's environment. I guess I'll feel alright if you spot check a few more and give me the green light. (Make sure you pull from GitHub again.)

@brandonpotvin
Copy link

@wibeasley I have tried most of the functions and all are working successfully. You have the green light to commit as far as I am concerned.

@wibeasley wibeasley mentioned this issue Sep 28, 2022
Merged
wibeasley added a commit that referenced this issue Sep 29, 2022
@wibeasley
missing handle_httr
9d23ba6 
ref #429

I'm not sure what happened between here and #432
@brandonpotvin
Copy link

👏 Thanks again @wibeasley , everything I have tried is working great! I appreciate your quick turn around in adding this parameter!

@wibeasley wibeasley mentioned this issue Oct 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wibeasley wibeasley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

accept httr handle OuhscBbmc/REDCapR
2 participants
@wibeasley @brandonpotvin