optimize write binlog by narrowing down critical secion #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e没过 |
现在应该done了，slave段的没改，死锁了。 |
AlexStocks
reviewed
Nov 21, 2023
AlexStocks
previously approved these changes
Nov 21, 2023
wangshao1
force-pushed
the
feature/optimize_binlog
branch
from
3496fbc to
da38b87
Compare
AlexStocks
approved these changes
Nov 21, 2023
dingxiaoshuai123
approved these changes
Nov 21, 2023
AlexStocks
added a commit
that referenced
this pull request
Nov 21, 2023
This reverts commit 6d7ad95.
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…dation#2129) Co-authored-by: wangshaoyi <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…dation#2129) Co-authored-by: wangshaoyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pika写binlog的过程拆分为encode command args + 写binlog文件。
之前的实现是先获取log最新的写入位点，然后encode command args + 写binlog文件，全程加锁直到写日志完成，加锁粒度大。
修改之后只在log类成员函数中写日志时加锁，之前拼接binlog日志内容部分并行执行，减小临界区。
使用redis-benchmark测试了下，256B的value-size时性能提升80%（只写binlog，不写storage）。
多rocksdb后，写binlog是瓶颈点，需要继续优化。