Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 2096: The setrange and setbit commands do not retain the expiration time of the original key #2095

Merged
merged 2 commits into from
Nov 4, 2023
Merged

fix issue 2096: The setrange and setbit commands do not retain the expiration time of the original key #2095

merged 2 commits into from
Nov 4, 2023

Conversation

u6th9d
Copy link
Contributor

@u6th9d u6th9d commented Nov 2, 2023 •
edited by AlexStocks
Loading

fix issue #2096

@AlexStocks
Copy link
Contributor

AlexStocks commented Nov 2, 2023 •
edited
Loading

thanks for your contribution to our project. what's more, would you please submit an issue firstly to explain what's the problem?

@u6th9d u6th9d mentioned this pull request Nov 2, 2023
Closed
@u6th9d u6th9d changed the title fix setrange/bitop cmd lost key expire time setrange和setbit命令没有保留原key的过期时间 Nov 2, 2023
@AlexStocks AlexStocks changed the title setrange和setbit命令没有保留原key的过期时间 fix issue 2096: The setrange and setbit commands do not retain the expiration time of the original key Nov 2, 2023
@AlexStocks
Copy link
Contributor

I have combine this pr with the issue 2096. And then, would you be pleased to add some tests in Golang for your code?

@AlexStocks AlexStocks merged commit d6ea4e2 into OpenAtomFoundation:unstable Nov 4, 2023
11 checks passed
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@u6th9d
fix issue 2096: The setrange and setbit commands do not retain the ex…
bddee25 
…piration time of the original key (OpenAtomFoundation#2095)

* fix setrange/bitop cmd lost key expire time

* Update string_test.go
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@u6th9d
fix issue 2096: The setrange and setbit commands do not retain the ex…
62d28b1 
…piration time of the original key (OpenAtomFoundation#2095)

* fix setrange/bitop cmd lost key expire time

* Update string_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingxiaoshuai123 dingxiaoshuai123 dingxiaoshuai123 approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@u6th9d @AlexStocks @dingxiaoshuai123