Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fixed the return value error of the decr command. #2092

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dingxiaoshuai123
Copy link
Collaborator

fixed the return value error of the "decr" command. #2061
filename: src/storage/src/redis_strings.cc line:352

before:
#2061

after:
截屏2023-11-02 11 45 35

int64_t ival = strtoll(old_user_value.c_str(), &end, 10);
if (*end != 0) {
if (errno == ERANGE || *end != 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

351 这行写死了 errno 的值,这里还用判断这个值吗?

@AlexStocks AlexStocks merged commit 94bee9c into OpenAtomFoundation:unstable Nov 2, 2023
11 checks passed
@dingxiaoshuai123 dingxiaoshuai123 deleted the decr_bug branch November 9, 2023 09:43
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants