chore: actions add cache #2088
Merged
chore: actions add cache #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
previously approved these changes
Oct 31, 2023
caifeizhi
reviewed
Oct 31, 2023
| uses: actions/cache@v3 | ||
| id: cache-ubuntu | ||
| with: | ||
| key: ${{ runner.os }}-build-ubuntu-${{ hashFiles('**/CMakeLists.txt') }} |
There was a problem hiding this comment.
Why is CMakeLists used here to calculate hash values?
Contributor
Author
There was a problem hiding this comment.
下面build命令行cmake用到cmakelists，cmakelist改变不能使用原来的缓存了
There was a problem hiding this comment.
好的；另外，这里我还有一个疑问，你这里缓存了整个workspace，会不会导致每次新增修改的代码，被缓存中的代码给覆盖掉，最终导致每次编译实际上都是用的旧的代码
AlexStocks
approved these changes
Nov 1, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2081