Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : go test on CI #2063

Merged
merged 4 commits into from
Oct 23, 2023
Merged

fix : go test on CI #2063

merged 4 commits into from
Oct 23, 2023

Conversation

dingxiaoshuai123
Copy link
Collaborator

由于异步FlushDB导致的测试失败概率较大，所以每次FlushDB之后增加1s延迟，确保不读到脏数据。#2046

chejinge
chejinge previously approved these changes Oct 9, 2023
View reviewed changes
@AlexStocks
Copy link
Contributor

Sleep 1s 就不会读到脏数据了？还是说读到的概率降低了？

@dingxiaoshuai123
Copy link
Collaborator Author

Sleep 1s 就不会读到脏数据了？还是说读到的概率降低了？

刚才调试了一下flushdb命令，我判断这个修改可能是有问题的，我明天再对一下。

@AlexStocks AlexStocks merged commit e3ea820 into OpenAtomFoundation:unstable Oct 23, 2023
11 checks passed
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@dingxiaoshuai123
fix : go test on CI (OpenAtomFoundation#2063)
a92e1b8 
* update rocksdb

* go test on CI

* go test on CI
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@dingxiaoshuai123
fix : go test on CI (OpenAtomFoundation#2063)
13e9e0c 
* update rocksdb

* go test on CI

* go test on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chejinge chejinge chejinge left review comments

@Mixficsol Mixficsol Mixficsol approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dingxiaoshuai123 @AlexStocks @chejinge @Mixficsol