fix: reduce exporter's non-essential logs #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixficsol
changed the title
AlexStocks
reviewed
Aug 29, 2023
tools/pika_exporter/exporter/conf.go
Outdated
| @@ -60,23 +60,23 @@ func readConfig(filePath string) error { | |||
|
|
|||
| // Display config | |||
| func (c *InfoConfig) Display() { | |||
There was a problem hiding this comment.
如果是这样子改进的话，还不如直接不调用这个函数，效果不是一样的吗？
There was a problem hiding this comment.
嗯嗯，这个不着急合，我确认一下DB那边的需求
如果是这样子改进的话，还不如直接不调用这个函数，效果不是一样的吗？
chejinge
approved these changes
Aug 31, 2023
luky116
approved these changes
Aug 31, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Co-authored-by: wuxianrong <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: wuxianrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1944
Screenshots
修改前：
修改后：
solution
去掉了 infoall 里面打印出的信息