clang-tidy: optimized part of the code using clang-tidy (the part before the narrowing conversion) #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 25, 2023 21:00
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
added 2 commits
July 10, 2023 15:46
…e, pstd modules(no problem local test)
chejinge
previously approved these changes
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
AlexStocks
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
luky116
reviewed
Jul 10, 2023
…, storage, pstd modules(no problem local test)" This reverts commit ec537fe.
AlexStocks
reviewed
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
approved these changes
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
previously approved these changes
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
chejinge
reviewed
Jul 10, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
longfar-ncy
commented
Jul 11, 2023
AlexStocks
approved these changes
Jul 11, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…ore the narrowing conversion) (OpenAtomFoundation#1701) * fix clang-analyzer-* * fix: clang-tidy checks clang-analyzer-* * fix: clang-tidy checks modernize-* * fix: clang-tidy checks performance-* * fix: cherry-pick the narrowing conversion fix code of the net, storage, pstd modules(no problem local test) * fix: fix a bug that existed in a previous fix for narrowing transitions * Revert "fix: cherry-pick the narrowing conversion fix code of the net, storage, pstd modules(no problem local test)" This reverts commit ec537fe. * Revert "fix: fix a bug that existed in a previous fix for narrowing transitions" This reverts commit 25ebaa4. * fix: changes based on recommendations made by the review * fix: changes based on recommendations made by the review * fix: make better --------- Co-authored-by: longfar <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…ore the narrowing conversion) (OpenAtomFoundation#1701) * fix clang-analyzer-* * fix: clang-tidy checks clang-analyzer-* * fix: clang-tidy checks modernize-* * fix: clang-tidy checks performance-* * fix: cherry-pick the narrowing conversion fix code of the net, storage, pstd modules(no problem local test) * fix: fix a bug that existed in a previous fix for narrowing transitions * Revert "fix: cherry-pick the narrowing conversion fix code of the net, storage, pstd modules(no problem local test)" This reverts commit ec537fe. * Revert "fix: fix a bug that existed in a previous fix for narrowing transitions" This reverts commit 25ebaa4. * fix: changes based on recommendations made by the review * fix: changes based on recommendations made by the review * fix: make better --------- Co-authored-by: longfar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the problem in the fix code of the narrowing conversion part, I need to troubleshoot one by one. So hoping to test the code before the narrowing transformation fix.