Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tcl tests for string #1675

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Added tcl tests for string #1675

merged 1 commit into from
Jul 3, 2023

Conversation

Mixficsol
Copy link
Collaborator

fix #1605

@@ -22,6 +22,7 @@ set ::all_tests {
unit/type/list-3
unit/type/set
unit/type/zset
unit/type/string
# unit/type/hash
# unit/sort
# unit/expire
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the actual code patch, it's challenging to provide a thorough code review. However, based on the information you provided, here are some general suggestions:

  1. Check for any syntax errors after adding the new line.
  2. Verify if the new unit test case for unit/type/string is correctly implemented, including proper assertions and expected outcomes.
  3. Uncomment or remove the commented out lines related to other unit tests (unit/type/hash, unit/sort, unit/expire) if they are not necessary in this code patch.
  4. Conduct thorough testing to ensure that the existing functionality of the code is not affected by the changes.

For a more detailed code review, please include the actual code patch or specific sections that require attention.

@machinly
Copy link
Collaborator

machinly commented Jul 3, 2023

请将无法通过的 case 添加至 #1605 的待修复列表中,以便后续跟进修复。

@machinly machinly requested review from machinly and chenbt-hz July 3, 2023 10:02
@Mixficsol
Copy link
Collaborator Author

请将无法通过的 case 添加至 #1605 的待修复列表中,以便后续跟进修复。

好的

@AlexStocks AlexStocks merged commit 90a2214 into OpenAtomFoundation:unstable Jul 3, 2023
@Mixficsol Mixficsol deleted the unittest branch August 2, 2023 01:48
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test To-Be-Fixed List | 单元测试待修复列表
3 participants