fix: remove new/delete in net #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ps:not all new/delete are removed, for the variable that has flexible life circle, I choose to keep them as they were.
|
net包中的修改: |
wanghenshui
changed the title
AlexStocks
approved these changes
May 16, 2023
luky116
approved these changes
May 22, 2023
chejinge
approved these changes
May 22, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* removed new/delete operation in /src/net/* and use smart ptr instead. Ps:not all new/delete are removed, for the variable that has flexible life circle, I choose to keep them as they were. * removed 2 delete operations that were skipped before * removed more unique_ptr --------- Co-authored-by: cjh <[email protected]>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* removed new/delete operation in /src/net/* and use smart ptr instead. Ps:not all new/delete are removed, for the variable that has flexible life circle, I choose to keep them as they were. * removed 2 delete operations that were skipped before * removed more unique_ptr --------- Co-authored-by: cjh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1477
removed new/delete operation in /src/net/* and use smart ptr instead.
Ps:not all new/delete are removed, for the variable that has flexible life circle, I choose to keep them as they were.