Skip to content

fix: Use inline variable in header files #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexStocks merged 1 commit into from
Apr 29, 2023
Merged

fix: Use inline variable in header files #1407

AlexStocks merged 1 commit into from
Apr 29, 2023

Conversation

@4kangjc
Copy link
Contributor

@4kangjc 4kangjc commented Apr 29, 2023

@4kangjc 4kangjc marked this pull request as draft April 29, 2023 05:50
@4kangjc 4kangjc marked this pull request as ready for review April 29, 2023 05:51
wanghenshui
wanghenshui approved these changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@wanghenshui wanghenshui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 7ccff45 into OpenAtomFoundation:unstable Apr 29, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@4kangjc
fix: Use inline variable (OpenAtomFoundation#1407)
9905576
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@4kangjc
fix: Use inline variable (OpenAtomFoundation#1407)
1426d73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@wanghenshui wanghenshui wanghenshui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@4kangjc @AlexStocks @wanghenshui