Skip to content

Commit cb10587

Browse files
josephfrazierstefanbuck
josephfrazier
authored and
stefanbuck
committed
Add gist support (#158)
* Add gist support Resolves #156 It turns out that the only thing preventing this from working (other than permissions) is determining the path associated with the Blob. Before, the path was undefined, so the Blob was not initialized properly. With this change, the path will be set to the filename entered into the gist. Assuming that that the filename is set to something reasonable, either the filename-based language detection or the github-based language detection will work correctly (at least, for non-relative links). Here's a test page: https://gist.github.com/josephfrazier/113827963013e98c6196db51cd889c39 --- Note that we may want to change the manifest.json `permissions` handling at https://github.com/OctoLinker/browser-extension/blob/ec499e065424b5204885624a297ab463c99fa8ab/package.json#L17 See here for prior discussion: #101 (comment) * blob-reader: add test for gist blob path
1 parent ec499e0 commit cb10587

File tree

4 files changed

+826
-0
lines changed

4 files changed

+826
-0
lines changed

‎assets/manifest.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
],
3737
"permissions": [
3838
"https://github.com/",
39+
"https://gist.github.com/",
3940
"https://githublinker.herokuapp.com/"
4041
]
4142
}

0 commit comments

Comments
 (0)