Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporal: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py #4736

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

temporal: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py #4736

wants to merge 2 commits into from
+365 −36

Conversation

arohanajit
Copy link
Contributor

Addresses multiple F401 linter warnings in the init.py file by replacing wildcard imports with explicit imports and defining the all variable to specify the public API of the module.

@github-actions github-actions bot added Python Related code is in Python libraries labels Nov 22, 2024
echoix
echoix previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it was did with the help of a tool the same way as the other PRs, it looks good to me. If there are some parts you'd want me to look more attentively in an IDE, tell me here before we merge

@arohanajit
Copy link
Contributor Author

Assuming it was did with the help of a tool the same way as the other PRs, it looks good to me. If there are some parts you'd want me to look more attentively in an IDE, tell me here before we merge

I basically listed out all function calls and added them. I had tried using GPT for this, but it misclassifies some functions like it did in a similar PR previously. Subsequently I ran isort on them

@echoix
Copy link
Member

echoix commented Nov 27, 2024

If you use vscode, why not activate pylance/pyright? It'll discover the methods and modules and you won't have to fear hallucinations. You'll have the autocomplete suggestions feeded through the LSP protocol.

@echoix
Copy link
Member

echoix commented Nov 27, 2024

I'll try to open it myself next time I'm on a computer with time for this.

@arohanajit
Copy link
Contributor Author

If you use vscode, why not activate pylance/pyright? It'll discover the methods and modules and you won't have to fear hallucinations. You'll have the autocomplete suggestions feeded through the LSP protocol.

Got it! I'll try it out next time I have a similar PR

@echoix echoix changed the title init: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py temporal: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py Nov 27, 2024
@echoix echoix dismissed their stale review November 27, 2024 22:36

To look at in IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
libraries Python Related code is in Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arohanajit @echoix