Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose solidity test runner config via user config #5837

Draft
wants to merge 4 commits into
base: v-next
Choose a base branch
from
Draft

feat: expose solidity test runner config via user config #5837

wants to merge 4 commits into from

Conversation

galargh
Copy link
Member

@galargh galargh commented Oct 21, 2024 •
edited
Loading

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR is a draft because we might want to leave it off until after the alpha.

This PR implements https://www.notion.so/nomicfoundation/Configuration-122578cdeaf58049a477dc4c585834f4

In particular, it:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a4f01e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:38am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 21, 2024
@galargh galargh changed the title Feat/solidity test configuration WIP: Explore how to configure solidity test task Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

hardhat

Total size of the bundle: 225M
Total number of dependencies (including transitive): 58

List of dependencies (sorted by size) 
220M	total
30M	@ignored/edr-optimism-linux-x64-musl
30M	@ignored/edr-optimism-linux-x64-gnu
27M	@ignored/edr-optimism-linux-arm64-musl
27M	@ignored/edr-optimism-linux-arm64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-darwin-x64
20M	esbuild
20M	@ignored/edr-optimism-darwin-arm64
8.9M	solc
2.8M	@sentry/tracing
1.9M	@noble/curves
1.7M	undici
1.2M	@sentry/types
1.2M	@noble/hashes
932K	@sentry/node
920K	@sentry/utils
824K	zod
796K	@ignored/hardhat-vnext-utils
576K	tsx
548K	@sentry/core
504K	fast-equals
492K	@scure/bip39
460K	@ignored/edr
384K	@ignored/edr-optimism
368K	ethereum-cryptography
344K	@sentry/hub
320K	enquirer
284K	semver
268K	@ignored/hardhat-vnext-errors
188K	commander
168K	@scure/base
136K	adm-zip
128K	get-tsconfig
96K	@scure/bip32
92K	chalk
88K	tslib
88K	@sentry/minimal
84K	js-sha3
76K	agent-base
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	lru_map
64K	https-proxy-agent
60K	@ignored/hardhat-vnext-zod-utils
56K	rfdc
56K	follow-redirects
48K	memorystream
48K	command-exists
48K	ansi-colors
44K	tmp
40K	resolve-pkg-maps
36K	p-map
32K	cookie
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	os-tmpdir
20K	ms

@galargh galargh force-pushed the feat/solidity-test-configuration branch from 2ecb430 to e62a664 Compare October 23, 2024 12:42
@galargh galargh force-pushed the feat/solidity-test-configuration branch from e62a664 to 27c734f Compare October 23, 2024 12:53
@galargh galargh force-pushed the feat/solidity-test-configuration branch from 27c734f to 3693970 Compare October 25, 2024 12:00
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Oct 25, 2024
@galargh galargh force-pushed the feat/solidity-test-configuration branch from 3693970 to 58fa591 Compare October 28, 2024 15:35
@galargh galargh changed the base branch from v-next to unified-test-workflow October 28, 2024 15:36
@galargh galargh changed the base branch from unified-test-workflow to v-next October 28, 2024 15:37
@galargh galargh force-pushed the feat/solidity-test-configuration branch from 58fa591 to 1c5f1a1 Compare October 28, 2024 15:37
@galargh galargh force-pushed the feat/solidity-test-configuration branch from 1c5f1a1 to b99dd9a Compare October 28, 2024 17:43
@galargh galargh changed the title WIP: Explore how to configure solidity test task feat: expose solidity test runner config via user config Oct 28, 2024
@galargh galargh force-pushed the feat/solidity-test-configuration branch from b99dd9a to 1131ca0 Compare October 28, 2024 18:11
@galargh galargh force-pushed the feat/solidity-test-configuration branch from 1131ca0 to 8d1e133 Compare October 28, 2024 18:13
@galargh galargh changed the title feat: expose solidity test runner config via user config [WIP] feat: expose solidity test runner config via user config Oct 28, 2024
@galargh galargh changed the title [WIP] feat: expose solidity test runner config via user config feat: expose solidity test runner config via user config Oct 28, 2024
@galargh galargh changed the title feat: expose solidity test runner config via user config [WIP] feat: expose solidity test runner config via user config Oct 28, 2024
@galargh galargh changed the title [WIP] feat: expose solidity test runner config via user config feat: expose solidity test runner config via user config Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galargh @alcuadrado