fix(detox): fixed android connectivity issues (#635)

codeprefect · web-flow · commit 28edd9ccd654 · 2025-06-30T10:02:00.000-07:00
diff --git a/packages/detox/README.md b/packages/detox/README.md
@@ -180,7 +180,36 @@ module.exports = {
 > **Note:** A default NativeScript Android project uses 17 as the minimum SDK, but Detox requires >=21. Remove or modify the `minSdkVersion` in your `App_Resources/Android/app.gradle`.
 
 
-### Allow Local Networking (**iOS Only**)
+### Allow Local Networking
+
+#### Android (Compulsory)
+
+We have added a network security config file at `./res/xml/network_security_config.xml`, add it to the applications `AndroidManifest.xml` as below
+
+```xml
+<!-- ./res/xml/network_security_config.xml -->
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+    <domain-config cleartextTrafficPermitted="true">
+        <domain includeSubdomains="true">10.0.2.2</domain>
+        <domain includeSubdomains="true">localhost</domain>
+    </domain-config>
+</network-security-config>
+```
+
+```xml
+<!-- ./res/xml/network_security_config.xml -->
+...existing code...
+
+  <application
+		...existing attributes...
+    android:networkSecurityConfig="@xml/network_security_config">
+...existing code...
+```
+
+If you have an existing network security config, incorporate the configuration specified above into it.
+
+#### iOS (Optional)
 
 Dependending on your setup iOS may not be able to communicate with Detox off the bat. In that case, you need to add the following to your `Info.plist` file to allow for local networking requests.
 
diff --git a/packages/detox/package.json b/packages/detox/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nativescript/detox",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Simplifies usage of wix/Detox e2e tests in NativeScript apps!",
   "main": "index",
   "typings": "index.d.ts",
@@ -13,8 +13,7 @@
   },
   "nativescript": {
     "platforms": {
-      "ios": "6.0.0",
-      "android": "6.0.0"
+      "android": "8.0.0"
     },
     "hooks": [
       {
@@ -32,7 +31,6 @@
     "NativeScript",
     "JavaScript",
     "TypeScript",
-    "iOS",
     "Android",
     "e2e",
     "testing",
diff --git a/packages/detox/platforms/android/AndroidManifest.xml b/packages/detox/platforms/android/AndroidManifest.xml
diff --git a/packages/detox/platforms/android/androidTest/AndroidManifest.xml b/packages/detox/platforms/android/androidTest/AndroidManifest.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    android:usesCleartextTraffic="true">
+
+    <!-- Required to target the app under test -->
+    <instrumentation
+        android:name="androidx.test.runner.AndroidJUnitRunner"
+        android:targetPackage="__PACKAGE__"
+        android:label="Detox Tests" />
+
+    <application>
+        <!-- No actual UI, but required to declare something in the test APK -->
+        <uses-library android:name="android.test.runner" />
+    </application>
+</manifest>
diff --git a/packages/detox/platforms/android/androidTest/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java b/packages/detox/platforms/android/androidTest/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java
@@ -0,0 +1,16 @@
+package com.facebook.react.modules.systeminfo;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class ReactNativeVersion {
+    public static final Map<String, Object> VERSION;
+
+    static {
+        VERSION = new HashMap<>();
+        VERSION.put("major", 99); // Arbitrary placeholder values
+        VERSION.put("minor", 0);
+        VERSION.put("patch", 0);
+        VERSION.put("prerelease", null);
+    }
+}
diff --git a/packages/detox/platforms/android/androidTest/java/com/tns/DetoxTest.java b/packages/detox/platforms/android/androidTest/java/com/tns/DetoxTest.java
@@ -1,6 +1,9 @@
 package com.tns;
 
+import com.tns.NativeScriptActivity;
+
 import com.wix.detox.Detox;
+import com.wix.detox.config.DetoxConfig;
 
 import org.junit.Rule;
 import org.junit.Test;
@@ -9,16 +12,28 @@
 import androidx.test.ext.junit.runners.AndroidJUnit4;
 import androidx.test.filters.LargeTest;
 import androidx.test.rule.ActivityTestRule;
+import android.util.Log;
 
 @RunWith(AndroidJUnit4.class)
 @LargeTest
 public class DetoxTest {
 
-    @Rule
-    public ActivityTestRule<com.tns.NativeScriptActivity> mActivityRule = new ActivityTestRule<>(com.tns.NativeScriptActivity.class, false, false);
+  @Rule
+  public ActivityTestRule<NativeScriptActivity> mActivityRule = new ActivityTestRule<NativeScriptActivity>(
+      NativeScriptActivity.class, false, false);
+
+  @Test
+  public void runDetoxTests() {
+    DetoxConfig detoxConfig = new DetoxConfig();
+    detoxConfig.idlePolicyConfig.masterTimeoutSec = 90;
+    detoxConfig.idlePolicyConfig.idleResourceTimeoutSec = 60;
+    detoxConfig.rnContextLoadTimeoutSec = getRuntimeTimeout();
+    Log.i("Detox", "&#128640; Starting Detox tests...");
+    Detox.runTests(mActivityRule, detoxConfig);
+    Log.i("Detox", "&#9989; Detox.runTests called");
+  }
 
-    @Test
-    public void runDetoxTests() {
-        Detox.runTests(mActivityRule);
-    }
-}
+  private static int getRuntimeTimeout() {
+    return "debug".equalsIgnoreCase(System.getenv("E2E_MODE")) ? 180 : 60;
+  }
+}
diff --git a/packages/detox/platforms/android/androidTest/java/com/tns/DetoxTestRunner.java b/packages/detox/platforms/android/androidTest/java/com/tns/DetoxTestRunner.java
diff --git a/packages/detox/platforms/android/include.gradle b/packages/detox/platforms/android/include.gradle
@@ -1,5 +1,5 @@
 repositories {
-  maven { url "$rootDir/../../node_modules/detox/Detox-android"}
+  maven { url = project.file('../../../node_modules/detox/Detox-android') }
 }
 
 dependencies {
@@ -8,15 +8,24 @@ dependencies {
 }
 
 android {
+  def testBase = project.file('../../../node_modules/@nativescript/detox/platforms/android/androidTest')
+
   defaultConfig {
-    minSdkVersion 18
-    sourceSets {
-        androidTest.setRoot("${project.rootDir}/../../node_modules/@nativescript/detox/platforms/android/androidTest")
-        androidTest {
-            java.srcDirs = ["${project.rootDir}/../../node_modules/@nativescript/detox/platforms/android/androidTest/java"]
-        }
-    }
     testBuildType System.getProperty('testBuildType', 'debug')
-    testInstrumentationRunner 'com.tns.DetoxTestRunner'
+    testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
+  }
+
+  sourceSets {
+    androidTest {
+      java.srcDirs += ["${testBase}/java"]
+      manifest.srcFile "${testBase}/AndroidManifest.xml"
+    }
+  }
+
+  buildTypes {
+    debug {
+      minifyEnabled false
+      shrinkResources false
+    }
   }
 }
diff --git a/packages/detox/platforms/android/res/xml/network_security_config.xml b/packages/detox/platforms/android/res/xml/network_security_config.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+    <domain-config cleartextTrafficPermitted="true">
+        <domain includeSubdomains="true">10.0.2.2</domain>
+        <domain includeSubdomains="true">localhost</domain>
+    </domain-config>
+</network-security-config>
