fix(vite): windows path handling

NathanWalker · NathanWalker · commit feef2231b67f · 2025-12-04T10:06:18.000-08:00
diff --git a/packages/vite/hmr/server/vite-plugin.ts b/packages/vite/hmr/server/vite-plugin.ts
@@ -1,5 +1,6 @@
 import type { Plugin, ResolvedConfig } from 'vite';
 import { createRequire } from 'node:module';
+import path from 'path';
 const require = createRequire(import.meta.url);
 
 const VIRTUAL_ID = 'virtual:ns-hmr-client';
@@ -20,7 +21,23 @@ export function nsHmrClientVitePlugin(opts: { platform: string; verbose?: boolea
 		load(id) {
 			if (id !== RESOLVED_ID) return null;
 
-			const clientPath = require.resolve('@nativescript/vite/hmr/client/index.js');
+			/**
+			 * Use a POSIX-style import specifier for the client entry to avoid
+			 * Windows drive-letter paths (e.g. "D:\\...") accidentally
+			 * becoming bare import ids that Rollup/Vite cannot resolve.
+			 * We still resolve the real filesystem path for correctness, but convert it to a project-relative POSIX path before interpolating it into the generated module.
+			 **/
+			const clientFsPath = require.resolve('@nativescript/vite/hmr/client/index.js');
+			// Prefer project root when available; otherwise fall back to cwd.
+			const projectRoot = config?.root || process.cwd();
+			let clientImport = clientFsPath;
+			try {
+				const rel = path.relative(projectRoot, clientFsPath).replace(/\\/g, '/');
+				clientImport = (rel.startsWith('.') ? rel : `/${rel}`).replace(/\/+/g, '/');
+			} catch {
+				// On any failure, keep the original path but normalize to POSIX
+				clientImport = clientFsPath.replace(/\\/g, '/');
+			}
 
 			// Build ws url from Vite server info
 			let host = process.env.NS_HMR_HOST || (config?.server?.host as any);
@@ -38,7 +55,7 @@ export function nsHmrClientVitePlugin(opts: { platform: string; verbose?: boolea
 			// Import client and start it with explicit ws URL
 			const banner = opts.verbose ? `console.log('[ns-hmr-client] starting client -> ${wsUrl} (HTTP loader enabled via __NS_HTTP_ORIGIN__)');` : '';
 			return `
-import startViteHMR from "${clientPath}";
+import startViteHMR from "${clientImport}";
 ${banner}
 startViteHMR({ wsUrl: ${JSON.stringify(wsUrl)} });
 `;
