feat: Node-API engine support (#10710)

NathanWalker · web-flow · commit fb57cf32815d · 2025-02-24T18:28:32.000-08:00
diff --git a/packages/core/ui/gestures/index.android.ts b/packages/core/ui/gestures/index.android.ts
@@ -1,6 +1,6 @@
 // Definitions.
 import { GestureEventData, TapGestureEventData, SwipeGestureEventData, PanGestureEventData, RotationGestureEventData, GestureEventDataWithState } from '.';
-import { View } from '../core/view';
+import type { View } from '../core/view';
 import { EventData } from '../../data/observable';
 
 // Types.
diff --git a/packages/core/ui/gestures/index.ios.ts b/packages/core/ui/gestures/index.ios.ts
@@ -1,7 +1,7 @@
 // Definitions.
 
 import { GestureEventData, TapGestureEventData, GestureEventDataWithState, SwipeGestureEventData, PanGestureEventData, RotationGestureEventData, PinchGestureEventData } from '.';
-import { View } from '../core/view';
+import type { View } from '../core/view';
 import { EventData } from '../../data/observable';
 
 // Types.
diff --git a/packages/core/ui/gestures/touch-manager.ts b/packages/core/ui/gestures/touch-manager.ts
@@ -5,7 +5,7 @@
 import { GestureEventData, GestureEventDataWithState, TouchGestureEventData } from '.';
 import { Animation } from '../animation';
 import { AnimationDefinition } from '../animation/animation-interfaces';
-import { View } from '../core/view';
+import type { View } from '../core/view';
 import { isObject, isFunction } from '../../utils/types';
 import { GestureEvents, GestureStateTypes, GestureTypes } from './gestures-common';
 
@@ -169,7 +169,7 @@ export class TouchManager {
 			}
 		}
 
-		view.on(View.disposeNativeViewEvent, (args) => {
+		view.on('disposeNativeView', (args) => {
 			const index = TouchManager.touchHandlers?.findIndex((handler) => handler.view === args.object);
 			if (index > -1) {
 				TouchManager.touchHandlers.splice(index, 1);
diff --git a/packages/core/ui/styling/style/index.ts b/packages/core/ui/styling/style/index.ts
@@ -43,7 +43,7 @@ export class Style extends Observable implements StyleDefinition {
 		super();
 
 		// HACK: Could not find better way for cross platform WeakRef type checking.
-		if (ownerView.constructor.toString().indexOf('[native code]') !== -1) {
+		if (ownerView.constructor.toString().indexOf('[native code]') !== -1 || ownerView.toString() == '[object WeakRef]') {
 			this.viewRef = <WeakRef<ViewBase>>ownerView;
 		} else {
 			this.viewRef = new WeakRef(<ViewBase>ownerView);
diff --git a/packages/webpack5/package-lock.json b/packages/webpack5/package-lock.json
diff --git a/packages/webpack5/src/loaders/nativescript-hot-loader/hmr.runtime.ts b/packages/webpack5/src/loaders/nativescript-hot-loader/hmr.runtime.ts
@@ -59,14 +59,15 @@ if (module.hot) {
 		},
 	};
 
-	const checkAndApply = async () => {
+	// Important: Keep as function and not fat arrow; at the moment hermes does not support them
+	const checkAndApply = async function () {
 		hash = __webpack_require__.h();
 		const modules = await module.hot.check().catch((error) => {
 			return setStatus(
 				hash,
 				'failure',
 				'Failed to check.',
-				error.message || error.stack
+				error.message || error.stack,
 			);
 		});
 
@@ -82,7 +83,7 @@ if (module.hot) {
 					hash,
 					'failure',
 					'Failed to apply.',
-					error.message || error.stack
+					error.message || error.stack,
 				);
 			});
 
