fix: corrected frame new unloaded handling

CatchABus · CatchABus · commit b2e3fbdbf786 · 2025-05-31T19:47:30.000+03:00
diff --git a/packages/core/ui/frame/frame-common.ts b/packages/core/ui/frame/frame-common.ts
@@ -144,11 +144,14 @@ export class FrameBase extends CustomLayoutView {
 
 	@profile
 	public onUnloaded() {
+		// Property page refers to the page this frame is nested into
+		const parentFrame = this.page?.frame;
+
 		super.onUnloaded();
 
 		// This is a precaution in case the method is called asynchronously during the loading procedure
-		if (this.hasListeners(FRAME_ENTRY_LOADED_EVENT)) {
-			this.off(FRAME_ENTRY_LOADED_EVENT);
+		if (parentFrame && parentFrame.hasListeners(FRAME_ENTRY_LOADED_EVENT)) {
+			parentFrame.off(FRAME_ENTRY_LOADED_EVENT);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -144,11 +144,14 @@ export class FrameBase extends CustomLayoutView {`
`144`	`144`
`145`	`145`	`@profile`
`146`	`146`	`public onUnloaded() {`
	`147`	`+ // Property page refers to the page this frame is nested into`
	`148`	`+ const parentFrame = this.page?.frame;`
	`149`	`+`
`147`	`150`	`super.onUnloaded();`
`148`	`151`
`149`	`152`	`// This is a precaution in case the method is called asynchronously during the loading procedure`
`150`		`- if (this.hasListeners(FRAME_ENTRY_LOADED_EVENT)) {`
`151`		`- this.off(FRAME_ENTRY_LOADED_EVENT);`
	`153`	`+ if (parentFrame && parentFrame.hasListeners(FRAME_ENTRY_LOADED_EVENT)) {`
	`154`	`+ parentFrame.off(FRAME_ENTRY_LOADED_EVENT);`
`152`	`155`	`}`
`153`	`156`	`}`
`154`	`157`