revert "feat(observable): enhance event callback type specificity" (#10721)

NathanWalker · web-flow · commit 922f6ce56aa5 · 2025-03-16T15:53:53.000-07:00
Revert "feat(observable): enhance event callback type specificity (#10720)" This reverts commit e2f9687.
diff --git a/packages/core/data/observable/index.ts b/packages/core/data/observable/index.ts
@@ -1,4 +1,4 @@
-import { Optional, EndsWith } from '../../utils/typescript-utils';
+import { Optional } from '../../utils/typescript-utils';
 
 /**
  * Base event data.
@@ -160,7 +160,7 @@ export class Observable {
 	 * `this` context when the callback is called. Falsy values will be not be
 	 * bound.
 	 */
-	public on<S extends string>(eventName: S, callback: (data: EndsWith<S, 'Change', PropertyChangeData, EventData>) => void, thisArg?: any): void {
+	public on(eventName: string, callback: (data: EventData) => void, thisArg?: any): void {
 		this.addEventListener(eventName, callback, thisArg);
 	}
 
@@ -175,7 +175,7 @@ export class Observable {
 	 * `this` context when the callback is called. Falsy values will be not be
 	 * bound.
 	 */
-	public once<S extends string>(eventName: S, callback: (data: EndsWith<S, 'Change', PropertyChangeData, EventData>) => void, thisArg?: any): void {
+	public once(eventName: string, callback: (data: EventData) => void, thisArg?: any): void {
 		this.addEventListener(eventName, callback, thisArg, true);
 	}
 
@@ -188,7 +188,7 @@ export class Observable {
 	 * @param thisArg An optional parameter which, when set, will be used to
 	 * refine search of the correct event listener to be removed.
 	 */
-	public off<S extends string>(eventName: S, callback?: (data: EndsWith<S, 'Change', PropertyChangeData, EventData>) => void, thisArg?: any): void {
+	public off(eventName: string, callback?: (data: EventData) => void, thisArg?: any): void {
 		this.removeEventListener(eventName, callback, thisArg);
 	}
 
diff --git a/packages/core/utils/typescript-utils.d.ts b/packages/core/utils/typescript-utils.d.ts
@@ -4,12 +4,3 @@
  * // returns: { eventName: string; object?: Observable }
  */
 export type Optional<T, K extends keyof T> = Omit<T, K> & { [P in K]?: T[P] };
-
-/**
- * Determines if a string type ends with a specified suffix.
- * @example type IsChangeEvent = EndsWith<"propertyNameChange", "Change", true, false>
- * // returns: true
- * @example type IsChangeEvent = EndsWith<"someEvent", "Change", true, false>
- * // returns: false
- */
-export type EndsWith<T extends string, S extends string, PassType = true, FailType = false> = T extends `${infer _}${S}` ? PassType : FailType;
